]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/buildid: skip over Mach-O UUID from buildid computation
authorCherry Mui <cherryyz@google.com>
Tue, 8 Oct 2024 16:42:33 +0000 (12:42 -0400)
committerCherry Mui <cherryyz@google.com>
Mon, 21 Oct 2024 17:56:28 +0000 (17:56 +0000)
commit0bb2183d45a1acec07470d9f041c55377217c8e2
tree24eeb8a01a08ad06b93897022246ef4dc824f3c5
parentf2d9f5ffcaf3aabaa8c8bd128a22fc07355f267e
cmd/internal/buildid: skip over Mach-O UUID from buildid computation

With the "-B gobuildid" linker option (which will be the default
on some platforms), the host build ID (GNU build ID, Mach-O UUID)
depends on the Go buildid. If the host build ID is included in the
Go buildid computation, it will lead to convergence problem for
the toolchain binaries. So ignore the host build ID in the buildid
computation.

This CL only handles Mach-O UUID. ELF GNU build ID will be handled
later.

For #68678.
For #63934.

Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64_14,gotip-darwin-arm64_13
Change-Id: Ie8ff20402a1c6083246d25dea391140c75be40d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/618597
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@golang.org>
src/cmd/internal/buildid/rewrite.go