]> Cypherpunks repositories - gostls13.git/commit
go/parser: avoid formatting a panic message if an assertion succeeds
authorRob Findley <rfindley@google.com>
Wed, 17 Mar 2021 16:42:19 +0000 (12:42 -0400)
committerRobert Findley <rfindley@google.com>
Wed, 17 Mar 2021 17:13:50 +0000 (17:13 +0000)
commit0bd308ff27822378dc2db77d6dd0ad3c15ed2e08
tree2cc925ca93eb1a309ca7ecb820ebfe2196a2eb46
parent70d54df4f6bd63b0057d718c6fc3fffc0d94bbc1
go/parser: avoid formatting a panic message if an assertion succeeds

tryResolve is an extremely hot method on the parser. Eliminating this
formatting led to a 20% performance improvement in BenchmarkParse.

Change-Id: Idf8850404bd72d45d1351356427a85086422ea68
Reviewed-on: https://go-review.googlesource.com/c/go/+/302629
Trust: Robert Findley <rfindley@google.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/go/parser/parser.go