]> Cypherpunks repositories - gostls13.git/commit
internal/trace: clean up parser.go
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 27 Jan 2025 21:42:34 +0000 (21:42 +0000)
committerGopher Robot <gobot@golang.org>
Tue, 11 Feb 2025 19:23:26 +0000 (11:23 -0800)
commit0be3701cb618713611fe3c21c13b2aee34020fff
treeee5d822a9f9872e8b872a7bd90156aa3ba5bee9e
parentb5f34aa4abc1ae49b9f97355deb5ab097d0c68a9
internal/trace: clean up parser.go

parser.go is an old file that contains trace v1 definitions and a second
equivalent definition for stack frames. These are redundant and useless.
Delete these definitions and rename the file to fakep.go, which
describes the only thing left in this file, a bunch of fake P IDs used
by the trace viewer.

We should consider moving the fake P definitions elsewhere, too.

Change-Id: Ifd0768bd73c39009069445afe0155f1e352f00c3
Reviewed-on: https://go-review.googlesource.com/c/go/+/644875
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/trace/pprof.go
src/cmd/trace/viewer.go
src/internal/trace/fakep.go [new file with mode: 0644]
src/internal/trace/parser.go [deleted file]
src/internal/trace/traceviewer/emitter.go
src/internal/trace/traceviewer/pprof.go