]> Cypherpunks repositories - gostls13.git/commit
runtime: show panics in traceback
authorAustin Clements <austin@google.com>
Fri, 12 Feb 2016 15:33:51 +0000 (10:33 -0500)
committerRuss Cox <rsc@golang.org>
Tue, 16 Feb 2016 16:58:43 +0000 (16:58 +0000)
commit0c02bc009a65763a5015e7efb95baec84bb79e8d
tree08fd710d2e294182c58e22ac614e041f0f63ae61
parent095c0e5c000a18f63c47009fd0684669cc602584
runtime: show panics in traceback

We used to include panic calls in tracebacks; however, when
runtime.panic was renamed to runtime.gopanic in the conversion of the
runtime to Go, we missed the special case in showframe that includes
panic calls even though they're in package runtime.

Fix the function name check in showframe (and, while we're here, fix
the other check for "runtime.panic" in runtime/pprof). Since the
"runtime.gopanic" name doesn't match what users call panic and hence
isn't very user-friendly, make traceback rewrite it to just "panic".

Updates #5832, #13857. Fixes #14315.

Change-Id: I8059621b41ec043e63d5cfb4cbee479f47f64973
Reviewed-on: https://go-review.googlesource.com/19492
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
src/runtime/crash_test.go
src/runtime/pprof/pprof.go
src/runtime/testdata/testprog/deadlock.go
src/runtime/traceback.go