]> Cypherpunks repositories - gostls13.git/commit
cmd/cgo/internal/testplugin: simplify TestForkExec and log stderr output
authorBryan C. Mills <bcmills@google.com>
Tue, 8 Aug 2023 16:02:02 +0000 (12:02 -0400)
committerGopher Robot <gobot@golang.org>
Tue, 8 Aug 2023 17:51:44 +0000 (17:51 +0000)
commit0c13bd637c87581c9f0f63d9cca57b80b8de2dc0
treefb2a8f2a550d51a88afa83c86cd9f0935ba54289
parent94e40d5603797fe4d9302421682bb5b997d9c568
cmd/cgo/internal/testplugin: simplify TestForkExec and log stderr output

This test used to run with a separate goroutine for timeout behavior,
presumably because it was difficult to set an appropriate timeout.

Now that the test is in cmd instead of misc, we can use
internal/testenv.Command, which makes adding the test timeout much
simpler and eliminates the need for the explicit goroutine.

For #61846.

Change-Id: I68ea09fcf2aa394bed1e900cf30ef7d143fa249f
Reviewed-on: https://go-review.googlesource.com/c/go/+/517095
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
src/cmd/cgo/internal/testplugin/plugin_test.go