]> Cypherpunks repositories - gostls13.git/commit
runtime, runtime/cgo: support using msan on cgo code
authorIan Lance Taylor <iant@golang.org>
Wed, 30 Sep 2015 04:24:13 +0000 (21:24 -0700)
committerIan Lance Taylor <iant@golang.org>
Wed, 30 Sep 2015 22:17:55 +0000 (22:17 +0000)
commit0c1f0549b893d9ddaab42a7765ba82234fbcc10d
tree6f0e6089d8bdac64096243e33ad7e773f17443a0
parentb72a4a07c257f394f5a96dff29a4fc862601a41f
runtime, runtime/cgo: support using msan on cgo code

The memory sanitizer (msan) is a nice compiler feature that can
dynamically check for memory errors in C code.  It's not useful for Go
code, since Go is memory safe.  But it is useful to be able to use the
memory sanitizer on C code that is linked into a Go program via cgo.
Without this change it does not work, as msan considers memory passed
from Go to C as uninitialized.

To make this work, change the runtime to call the C mmap function when
using cgo.  When using msan the mmap call will be intercepted and marked
as returning initialized memory.

Work around what appears to be an msan bug by calling malloc before we
call mmap.

Change-Id: I8ab7286d7595ae84782f68a98bef6d3688b946f9
Reviewed-on: https://go-review.googlesource.com/15170
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
misc/cgo/testsanitizers/msan.go [new file with mode: 0644]
misc/cgo/testsanitizers/test.bash [new file with mode: 0755]
src/cmd/dist/test.go
src/runtime/cgo/gcc_linux_amd64.c
src/runtime/cgo/gcc_mmap.c [new file with mode: 0644]
src/runtime/cgo/mmap.go [new file with mode: 0644]
src/runtime/cgo_mmap.go [new file with mode: 0644]
src/runtime/mmap.go [new file with mode: 0644]
src/runtime/stubs2.go
src/runtime/sys_linux_amd64.s