]> Cypherpunks repositories - gostls13.git/commit
cmd/go, go/build: implement import comment checking
authorRuss Cox <rsc@golang.org>
Tue, 12 Aug 2014 21:41:03 +0000 (17:41 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 12 Aug 2014 21:41:03 +0000 (17:41 -0400)
commit0c6146711c184b711c9d2d664056380e149fa714
tree331b2c6c9621e25c779bf99c0cb90373f6517e59
parentf497885c6343808b47811981ae42c2e816005163
cmd/go, go/build: implement import comment checking

See golang.org/s/go14customimport for design.

Added case to deps_test to allow go/build to import regexp.
Not a new dependency, because go/build already imports go/doc
which imports regexp.

Fixes #7453.

LGTM=r
R=r, josharian
CC=golang-codereviews
https://golang.org/cl/124940043
13 files changed:
src/cmd/go/pkg.go
src/cmd/go/test.bash
src/cmd/go/testdata/importcom/bad.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/conflict.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/src/bad/bad.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/src/conflict/a.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/src/conflict/b.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/src/works/x/x.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/src/works/x/x1.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/src/wrongplace/x.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/works.go [new file with mode: 0644]
src/cmd/go/testdata/importcom/wrongplace.go [new file with mode: 0644]
src/pkg/go/build/build.go