]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.5] cmd/compile: fix crash with -race on large expr containing...
authorRuss Cox <rsc@golang.org>
Wed, 18 Nov 2015 19:37:12 +0000 (14:37 -0500)
committerRuss Cox <rsc@golang.org>
Mon, 23 Nov 2015 01:13:14 +0000 (01:13 +0000)
commit0c64370422a0aebc180881bd9ae0a69fa8116a0c
tree3eed703970885e189bd409593a453db6715b4da4
parent29a22abfc8c81be7c3676f385fb0f2caf3029543
[release-branch.go1.5] cmd/compile: fix crash with -race on large expr containing string->[]byte conversion

The assumption is that there are no nested function calls in complex expressions.
For the most part that assumption is true. It wasn't for these calls inserted during walk.
Fix that.

I looked through all the calls to mkcall in walk and these were the only cases
that emitted calls, that could be part of larger expressions (like not delete),
and that were not already handled.

Fixes #12225.

Change-Id: Iad380683fe2e054d480e7ae4e8faf1078cdd744c
Reviewed-on: https://go-review.googlesource.com/17034
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/17125
src/cmd/compile/internal/gc/order.go
src/runtime/race/testdata/issue12225_test.go [new file with mode: 0644]