]> Cypherpunks repositories - gostls13.git/commit
cmd/go: do not try to load 'all' packages with invalid import paths
authorMichael Matloob <matloob@golang.org>
Fri, 16 May 2025 20:40:55 +0000 (16:40 -0400)
committerMichael Matloob <matloob@google.com>
Tue, 20 May 2025 17:51:31 +0000 (10:51 -0700)
commit0c7311e9ca8440801b40928878db623f98e3008f
tree10c71bf343b0f7b4577abac1de987dc2cf229427
parent3e82316a4357c44c193790bdc02d1f8032f34289
cmd/go: do not try to load 'all' packages with invalid import paths

Before this change, when we tried to compute the set of packages in
'all', we'd add packages with invalid import paths to the set and try to
load them, which would fail. Instead, do not add them to the list of
packages to load in the second iteration of the loader. We'll still
return errors for invalid imports in the importing packages.
Change-Id: I682229011f555ed1d0c827f79100c1c43bf7f93a
Reviewed-on: https://go-review.googlesource.com/c/go/+/673655
Reviewed-by: Michael Matloob <matloob@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/go/internal/modload/load.go
src/cmd/go/testdata/script/list_empty_importpath.txt [new file with mode: 0644]