]> Cypherpunks repositories - gostls13.git/commit
debug/elf: adjust version API per issue discussion
authorIan Lance Taylor <iant@golang.org>
Wed, 11 Dec 2024 03:48:11 +0000 (19:48 -0800)
committerGopher Robot <gobot@golang.org>
Wed, 11 Dec 2024 23:40:12 +0000 (15:40 -0800)
commit0ca521f9c1a6357578b501615f073adb2da6b527
tree50ad49b74fce9c88a012b2ee3f5f75a808fb7fa1
parentc93477b5e563dd0ed7b45fd519762f24b7cfa7b0
debug/elf: adjust version API per issue discussion

This updates the new version API for the discussion on #63952.

This change reveals that in fact none of the tests set the
VERSYM_HIDDEN bit. The code before this CL set the hidden flag
for symbols that appear in DynamicVersionNeed, but that is not
an accurate representation of the ELF. The readelf program
does print undefined symbols that way (with a single '@'),
but that doesn't mean that the hidden flag is set.
Leaving tests with the hidden bit set for later.

For #63952

Change-Id: Ida60831e0c9922dfc10f10c7a64bc76a2b197537
Reviewed-on: https://go-review.googlesource.com/c/go/+/635079
Reviewed-by: Austin Clements <austin@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
api/go1.24.txt
src/debug/elf/file.go
src/debug/elf/file_test.go
src/debug/elf/symbols_test.go