]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.2] runtime: if traceback sees a breakpoint, don't change the PC
authorRuss Cox <rsc@golang.org>
Fri, 28 Feb 2014 03:43:47 +0000 (22:43 -0500)
committerRuss Cox <rsc@golang.org>
Fri, 28 Feb 2014 03:43:47 +0000 (22:43 -0500)
commit0d2f5c0e3b4cddd4bd8349169e0c29e0862b44e3
tree727788e3c96ce021ccf953677f0cf1283ea32f52
parent495b91430f7914b221d7507e60b065733e2d34c4
[release-branch.go1.2] runtime: if traceback sees a breakpoint, don't change the PC

««« CL 49580044 / 38cd458b1dfe
runtime: if traceback sees a breakpoint, don't change the PC

Changing the PC confuses gdb, because execution does not
continue where gdb expects it.  Not changing the PC has the
potential to confuse a stack dump, but when running under gdb
it seems better to confuse a stack dump than to confuse gdb.

Fixes #6776.

LGTM=rsc
R=golang-codereviews, dvyukov, rsc
CC=golang-codereviews
https://golang.org/cl/49580044
»»»

LGTM=r
R=golang-codereviews, r
CC=golang-dev
https://golang.org/cl/69800043
src/pkg/runtime/sys_x86.c