]> Cypherpunks repositories - gostls13.git/commit
internal/syscall/windows/registry: remove TestWalkFullRegistry due to false assumptions
authorJason A. Donenfeld <Jason@zx2c4.com>
Sat, 26 Oct 2019 21:05:22 +0000 (23:05 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Sun, 27 Oct 2019 09:45:42 +0000 (09:45 +0000)
commit0d3092ffa7e7f613429ddcfd596d26ccbc84766f
tree879f146fd88a7824f2b0bce8b008c917cb61208e
parent0f559941fbd17acace0f7ce307d50c85d6941e19
internal/syscall/windows/registry: remove TestWalkFullRegistry due to false assumptions

This test's existence was predicated upon assumptions about the full
range of known data types and known data into those types. However,
we've learned from Microsoft that there are several undocumented secret
registry types that are in use by various parts of Windows, and we've
learned from inspection that many Microsoft uses of registry types don't
strictly adhere to the recommended value size. It's therefore foolhardy
to make any assumptions about what goes in and out of the registry, and
so this test, as well as its "blacklist", are meaningless.

Fixes #35084

Change-Id: I6c3fe5fb0e740e88858321b3b042c0ff1a23284e
Reviewed-on: https://go-review.googlesource.com/c/go/+/203604
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
src/internal/syscall/windows/registry/registry_test.go