]> Cypherpunks repositories - gostls13.git/commit
path/filepath: fix Win32 tests missing 'chcp'
authorLubomir I. Ivanov (VMware) <neolit123@gmail.com>
Wed, 25 Apr 2018 20:59:04 +0000 (20:59 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 26 Apr 2018 18:25:15 +0000 (18:25 +0000)
commit0d54fb5610fb054e08a77f2a68a4df145182ae8e
treed616a247b0c504640b3df28f58b7a1ac1afafc56
parentd9a50a6531860b43e552656e2990b87e36c8e440
path/filepath: fix Win32 tests missing 'chcp'

'%SystemRoot%/System32/chcp.com' is a tool on Windows that
is used to change the active code page in the console.

'go test path/filepath' can fail with:
"'chcp' is not recognized as an internal or external command"

The test uses a custom PATH variable but does not include
'%SystemRoot%/System32'. Always append that to PATH.

Updates #24709

Change-Id: Ib4c83ffdcc5dd6eb7bb34c07386cf2ab61dcae57
GitHub-Last-Rev: fac92613cce0d60f6794ad850618ed64d04c76fd
GitHub-Pull-Request: golang/go#25089
Reviewed-on: https://go-review.googlesource.com/109362
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/path/filepath/path_windows_test.go