]> Cypherpunks repositories - gostls13.git/commit
net/http: log call site which causes multiple header writes
authorDavid Url <david@urld.io>
Thu, 23 Aug 2018 15:28:59 +0000 (17:28 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 3 Oct 2018 15:29:15 +0000 (15:29 +0000)
commit0df9fa2ebec975359c8ee1150ecf7f28f12b39ee
tree6f2d53b6454b9e49136d9f078c2b594ea0bf0355
parentb8ac64a581b1e8e033cd7c9919d7dcf8fb16d17b
net/http: log call site which causes multiple header writes

If an illegal header write is detected, find the first caller outside of
net/http using runtime.CallersFrames and include the call site in the log
message.

Fixes #18761

Change-Id: I92be00ac206c6ebdd60344ad7bf40a7c4c188547
Reviewed-on: https://go-review.googlesource.com/c/130997
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/http/clientserver_test.go
src/net/http/server.go