]> Cypherpunks repositories - gostls13.git/commit
cmd/link: improve gap detection in TestPIESize
authorCherry Zhang <cherryyz@google.com>
Mon, 24 Feb 2020 21:24:29 +0000 (16:24 -0500)
committerCherry Zhang <cherryyz@google.com>
Tue, 25 Feb 2020 02:17:17 +0000 (02:17 +0000)
commit0fb1a49c1ae0e9e587c74947d6d6c3fe92c161df
tree4c7009172a7d4fa0de04e855b00b9ca55028abc7
parente0c3ded337e95ded40eb401e7d9e74716e3a445f
cmd/link: improve gap detection in TestPIESize

In CL 210180 we detect gaps between PT_LOAD segments and subtract
them from size calculation. The code there only works when
PT_LOAD segments are next to each other. But it is possible that
there are other segments in between (e.g. a GNU_RELRO segment).
Relax the gap detection to count gaps between PT_LOAD segments
regardless of whether they are next to each other.

Updates #36023.
Updates #35545.

Change-Id: I8b94506359fa649a4478acc742d86d4b16022dbc
Reviewed-on: https://go-review.googlesource.com/c/go/+/220654
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/link/elf_test.go