]> Cypherpunks repositories - gostls13.git/commit
net/http: deflake TestServerKeepAlivesEnabled_h{1,2}
authorDamien Neil <dneil@google.com>
Tue, 2 Nov 2021 18:52:36 +0000 (11:52 -0700)
committerDamien Neil <dneil@google.com>
Tue, 2 Nov 2021 19:37:42 +0000 (19:37 +0000)
commit1011e26b9cec8b5e7b0b827805b2fe079904521a
tree69fdefd76b53206af9f86e739d821984af7133c7
parent80a7968842895a5c05efa6464ce49b62413436c1
net/http: deflake TestServerKeepAlivesEnabled_h{1,2}

This test assumes that two successive TCP connections will use different
source ports. This does not appear to be a universally safe assumption.

Rewrite the test to use httptrace to detect connection reuse instead.

Fixes #46707

Change-Id: Iebfbdfdeb77a1e6663a0c654dc847cc270c5d54d
Reviewed-on: https://go-review.googlesource.com/c/go/+/360854
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/net/http/serve_test.go