]> Cypherpunks repositories - gostls13.git/commit
os: improve Windows fixLongPath
authorKir Kolyshkin <kolyshkin@gmail.com>
Wed, 21 Aug 2024 22:11:38 +0000 (15:11 -0700)
committerDamien Neil <dneil@google.com>
Thu, 22 Aug 2024 20:04:04 +0000 (20:04 +0000)
commit10ed134afe1319403a9a6a8b6bb798f29e5a4d5e
tree703db2ded19dabaf7297737867c4d18eae3c0920
parentd2879efd0227df32d6aeee1be58c325b477f22d4
os: improve Windows fixLongPath

CL 574695 added caching the os.Chdir argument for Windows, and used the
cached value to assess the length of the current working directory in
addExtendedPrefix (used by fixLongPath).

It did not take into account that Chdir can accept relative paths, and
thus the pathLength calculation in addExtendedPrefix can be wrong.

Let's only cache the os.Chdir argument if it's absolute, and clean the
cache otherwise, thus improving the correctness of fixLongPath.

For #41734
For #21782
For #36375

Change-Id: Ie24a5ed763a7aacc310666d2e4cbb8e298768670
Reviewed-on: https://go-review.googlesource.com/c/go/+/607437
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/os/file.go