]> Cypherpunks repositories - gostls13.git/commit
cmd/go, cmd/link, cmd/dist: re-enable plugin mode on darwin/amd64
authorHiroshi Ioka <hirochachacha@gmail.com>
Mon, 4 Sep 2017 12:23:29 +0000 (21:23 +0900)
committerDavid Crawshaw <crawshaw@golang.org>
Sun, 10 Sep 2017 12:54:13 +0000 (12:54 +0000)
commit1134411a833caa79017a1fffb9dd9afb102d5da9
treeb831ac0e0fd9e7566c6a90b2c83c045510c44bed
parent1053ae5cf51bcc9d0b38c087880dda49b4825e0f
cmd/go, cmd/link, cmd/dist: re-enable plugin mode on darwin/amd64

1. remove broken verification
   The runtime check assumes that no-pcln symbol entry have zero value,
   but the linker emit no entries if the symbol is no-pcln.
   As a result, if there are no-pcln symbols at the very end of pcln
   table, it will panic.
2. correct condition of export
   Handle special chracters in pluginpath correcty.
   Export "go.itab.*", so different plugins can share the same itab.

Fixes #18190

Change-Id: Ia4f9c51d83ce8488a9470520f1ee9432802cfc1d
Reviewed-on: https://go-review.googlesource.com/61091
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
misc/cgo/testplugin/test.bash
src/cmd/dist/test.go
src/cmd/go/internal/work/build.go
src/cmd/link/internal/ld/macho.go
src/runtime/symtab.go