]> Cypherpunks repositories - gostls13.git/commit
go/types: simplify method set computation
authorRobert Griesemer <gri@golang.org>
Sat, 8 Feb 2020 00:01:01 +0000 (16:01 -0800)
committerRobert Griesemer <gri@golang.org>
Mon, 2 Mar 2020 22:19:08 +0000 (22:19 +0000)
commit117297cf42c5fd96fc1392e600c8d62d3bba7c5f
tree095a74f0f247a64b0ce8f0605604dcefd658441a
parentca3dd1d36b5aa2dd810d31ec425a32902ae50ba9
go/types: simplify method set computation

After fixing #37081 we don't need to explicitly keep track of
field collisions in the method set computation anymore; we only
need to know which field (names) exists at each embedding level.
Simplify the code by removing the dedicated fieldSet data type
in favor of a simple string set.

Follow-up on https://golang.org/cl/218617; separate CL to make it
easier to identify a problem with these two changes, should there
be one.

Updates #37081.

Change-Id: I5c259c63c75a148a42d5c3e1e4860e1ffe5631bd
Reviewed-on: https://go-review.googlesource.com/c/go/+/218618
Reviewed-by: Alan Donovan <adonovan@google.com>
src/go/types/methodset.go