]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.19] go/scanner: reject large line and column numbers in //line...
authorDamien Neil <dneil@google.com>
Wed, 22 Mar 2023 16:33:22 +0000 (09:33 -0700)
committerGopher Robot <gobot@golang.org>
Tue, 4 Apr 2023 16:47:49 +0000 (16:47 +0000)
commit126a1d02da82f93ede7ce0bd8d3c51ef627f2104
treeec8781ec9aae95ca1c524b7efd8eef71a25e5cbf
parent7917b5f31204528ea72e0629f0b7d52b35b27538
[release-branch.go1.19] go/scanner: reject large line and column numbers in //line directives

Setting a large line or column number using a //line directive can cause
integer overflow even in small source files.

Limit line and column numbers in //line directives to 2^30-1, which
is small enough to avoid int32 overflow on all reasonbly-sized files.

Fixes CVE-2023-24537
Fixes #59273
For #59180

Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1802456
Reviewed-by: Julie Qiu <julieqiu@google.com>
Reviewed-by: Roland Shoemaker <bracewell@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1802611
Reviewed-by: Damien Neil <dneil@google.com>
Change-Id: Ifdfa192d54f722d781a4d8c5f35b5fb72d122168
Reviewed-on: https://go-review.googlesource.com/c/go/+/481986
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
src/go/parser/parser_test.go
src/go/scanner/scanner.go