]> Cypherpunks repositories - gostls13.git/commit
net/http: verify RoundTripper invariants in the send function
authorBryan C. Mills <bcmills@google.com>
Mon, 2 Mar 2020 15:16:39 +0000 (10:16 -0500)
committerBryan C. Mills <bcmills@google.com>
Mon, 2 Mar 2020 15:39:23 +0000 (15:39 +0000)
commit12d02e7d8e7df75ccbf07ec40028329fcc35c55b
treedcb8b6aa910b6776f1adb46efa9766b341f5f0c3
parentacac535c3ca571beeb168c953d6d672f61387ef1
net/http: verify RoundTripper invariants in the send function

Issue #37598 reports a nil-panic in *Client.send that can
only occur if one of the RoundTripper invariants is violated.
Unfortunately, that condition is currently difficult to diagnose: it
manifests as a panic during a Response field access, rather than
something the user can easily associate with an specific erroneous
RoundTripper implementation.

No test because the new code paths are supposed to be unreachable.

Updates #37598

Change-Id: If0451e9c6431f6fab7137de43727297a80def05b
Reviewed-on: https://go-review.googlesource.com/c/go/+/221818
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/client.go