]> Cypherpunks repositories - gostls13.git/commit
cmd/link: use BestSpeed for DWARF compression
authorAustin Clements <austin@google.com>
Wed, 11 Jul 2018 20:13:04 +0000 (16:13 -0400)
committerAustin Clements <austin@google.com>
Wed, 11 Jul 2018 20:23:02 +0000 (20:23 +0000)
commit12ed0ddec198db0eaabbaaef28bb5ffb17204e11
treec4344fa2cd5d5310ba30ed39c5e96ef944a7eb6a
parent9300d223a3986b4419372bcd58c6cce7c845e8ae
cmd/link: use BestSpeed for DWARF compression

DWARF compression accounts for roughly 30% of the linker's time. This
CL switches from DefaultCompression to BestSpeed, which virtually
eliminates this time. This roughly halves the overhead of handling
DWARF in the linker:

name \ time/op         nodwarf     dwarf        dwarf-speed
BuildCmdGoAll          10.0s ±11%   10.6s ± 5%   10.8s ± 5%
             nodwarf                  +6.41%       +8.03%
               dwarf                                 ~
LinkCmdGo              626ms ± 5%  1096ms ± 2%   860ms ± 2%
             nodwarf                 +75.17%      +37.36%
               dwarf                              -21.59%

Previously, enabling DWARF had a 75% overhead in link time for cmd/go.
This change reduces this overhead to 37% (a 22% reduction).

The effect on binary size is minimal compared to DefaultCompression,
and still substantially better than no compression:

             cmd/go bytes
nodwarf      10106953
dwarf        12159049 nodwarf+20%
dwarf-speed  12408905 nodwarf+23%
dwarf-nozlib 17766473 nodwarf+76%

Updates #26318.

Change-Id: I33bb7caa038a2753c29104501663daf4839e7054
Reviewed-on: https://go-review.googlesource.com/123356
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/link/internal/ld/data.go