]> Cypherpunks repositories - gostls13.git/commit
cmd/dist: log CPU model when testing
authorMichael Pratt <mpratt@google.com>
Mon, 13 Dec 2021 22:32:07 +0000 (17:32 -0500)
committerMichael Pratt <mpratt@google.com>
Fri, 14 Jan 2022 18:36:41 +0000 (18:36 +0000)
commit1302f93c4e1eae0e625b372f9bb6bb48780af30f
tree1e937d0aa089ab67c6a4f072a183268e2c79744b
parente4a6b84962cc2fb4f4b8bb532a84bab5bfd68d99
cmd/dist: log CPU model when testing

Knowing whether test failures are correlated with specific CPU models on
has proven useful on several issues. Log it for prior to testing so it
is always available.

internal/sysinfo provides the CPU model, but it is not available in the
bootstrap toolchain, so we can't access this unconditionally in
cmd/dist. Instead use a build-tagged file, as the final version of
cmd/dist will use the final toolchain.

The addition of new data to the beginning of cmd/dist output will break
x/build/cmd/coordinator's banner parsing, leaving extra lines in the log
output, though information will not be lost.
https://golang.org/cl/372538 fixes up the coordinator and should be
submitted and deployed before this CL is submitted.

For #46272.
For #49209.
For #50146.

Change-Id: I515d2ec58e4c0034b76bf624ecaab38f16146074
Reviewed-on: https://go-review.googlesource.com/c/go/+/371474
Trust: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/dist/metadata.go [new file with mode: 0644]
src/cmd/dist/metadata_bootstrap.go [new file with mode: 0644]
src/cmd/dist/sys_windows.go
src/cmd/dist/test.go