]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.18] cmd/compile: disable rewrite loop detector for deadcode-only...
authorKeith Randall <khr@golang.org>
Mon, 14 Mar 2022 22:17:43 +0000 (15:17 -0700)
committerHeschi Kreinick <heschi@google.com>
Mon, 9 May 2022 20:24:02 +0000 (20:24 +0000)
commit13bda0ebfb00a84bfb422985c62914f2bcb62a40
tree7495463e7bf7b57363d18ef1c05ba0815c4ff77c
parent02878959960b6d09639841324693b3ab92d5f486
[release-branch.go1.18] cmd/compile: disable rewrite loop detector for deadcode-only changes

We're guaranteed we won't infinite loop on deadcode-only changes,
because each change converts valid -> invalid, and there are only a
finite number of valid values.

The loops this test is looking for are those generated by rule
applications, so it isn't useful to check for loops when rules aren't
involved.

Fixes #52366

Change-Id: Idf1abeab9d47baafddc3a1197d5064faaf07ef78
Reviewed-on: https://go-review.googlesource.com/c/go/+/392760
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
(cherry picked from commit 15728ce950eea43d6f1b9fb29819d006071e843a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/400514
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/ssa/rewrite.go