]> Cypherpunks repositories - gostls13.git/commit
cmd/go: don't start upload until after toolchain selection
authorMichael Matloob <matloob@golang.org>
Mon, 13 May 2024 18:59:02 +0000 (14:59 -0400)
committerMichael Matloob <matloob@golang.org>
Wed, 15 May 2024 21:51:49 +0000 (21:51 +0000)
commit13d36a9b46c7beeb49ffc623d5ab0568840b277b
tree3434119e6d9453166261ed9471305a49f3889b89
parent7730e5b78308b966a1fe913cdd3086c84e0a2e25
cmd/go: don't start upload until after toolchain selection

Run telemetry.Start (without the upload) first thing so we can increment
counters in toolchain selection. Then run telemetry.StartWithUpload
after toolchain selection so we don't start the upload until after
toolchain selection has happened so we don't start something heavyweight
before selection.

Change-Id: Ia8979175a163265c3e29f6cb11a4ada4714d1d95
Reviewed-on: https://go-review.googlesource.com/c/go/+/585419
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
src/cmd/go/main.go