]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: use proved bounds to remove signed division fix-ups
authorChrisALiles <caveryliles@gmail.com>
Mon, 6 Aug 2018 09:50:38 +0000 (19:50 +1000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 23 Oct 2018 02:29:44 +0000 (02:29 +0000)
commit13d5cd784748f8849c75ec23ed6e3d40dc7d2ce7
tree5bbce64c3e0bd9852e9c5111f474a22b61932389
parent47cc59f31f8e2ef18ee34402be7b94cbe39638aa
cmd/compile: use proved bounds to remove signed division fix-ups

prove is able to find 94 occurrences in std cmd where a divisor
can't have the value -1. The change removes
the extraneous fix-up code for these cases.

Fixes #25239

Change-Id: Ic184de971f47cc57c702eb72805b8e291c14035d
Reviewed-on: https://go-review.googlesource.com/c/130215
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
14 files changed:
src/cmd/compile/internal/amd64/ssa.go
src/cmd/compile/internal/gc/testdata/arith_test.go
src/cmd/compile/internal/ssa/gen/386.rules
src/cmd/compile/internal/ssa/gen/386Ops.go
src/cmd/compile/internal/ssa/gen/AMD64.rules
src/cmd/compile/internal/ssa/gen/AMD64Ops.go
src/cmd/compile/internal/ssa/gen/genericOps.go
src/cmd/compile/internal/ssa/opGen.go
src/cmd/compile/internal/ssa/prove.go
src/cmd/compile/internal/ssa/rewrite.go
src/cmd/compile/internal/ssa/rewrite386.go
src/cmd/compile/internal/ssa/rewriteAMD64.go
src/cmd/compile/internal/x86/ssa.go
test/codegen/arithmetic.go