]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.15] cmd/compile: allow aliases to go:notinheap types
authorKeith Randall <khr@golang.org>
Wed, 26 Aug 2020 21:07:35 +0000 (14:07 -0700)
committerDmitri Shuralyov <dmitshur@golang.org>
Fri, 9 Oct 2020 17:24:56 +0000 (17:24 +0000)
commit142027888a7d3da0494d77581166f1d120317864
tree37196f75d5bb7ab5af28e2ff13b2f2ea33d2d7df
parent439ce71eb6a472c5f758021a92f06d8489ca0689
[release-branch.go1.15] cmd/compile: allow aliases to go:notinheap types

The alias doesn't need to be marked go:notinheap. It gets its
notinheap-ness from the target type.

Without this change, the type alias test in the notinheap.go file
generates these two errors:

notinheap.go:62: misplaced compiler directive
notinheap.go:63: type nih must be go:notinheap

The first is a result of go:notinheap pragmas not applying
to type alias declarations.
The second is the result of then trying to match the notinheap-ness
of the alias and the target type.

Add a few more go:notinheap tests while we are here.

Update #40954

Change-Id: I067ec47698df6e9e593e080d67796fd05a1d480f
Reviewed-on: https://go-review.googlesource.com/c/go/+/250939
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Trust: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/255337
Trust: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/compile/internal/gc/typecheck.go
test/notinheap.go
test/notinheap2.go