]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.8] cmd/go: clean up x.exe properly in TestImportMain
authorRuss Cox <rsc@golang.org>
Tue, 17 Oct 2017 19:10:59 +0000 (15:10 -0400)
committerRuss Cox <rsc@golang.org>
Wed, 25 Oct 2017 18:57:08 +0000 (18:57 +0000)
commit142d4490813ec7e72dfc4c248bf71e2c2f53ffa1
tree9935f667a1485f29b53f42a7fdb0e7cd6d588997
parent533ee44cd45c064608ee2b833af9e86ef1cb294e
[release-branch.go1.8] cmd/go: clean up x.exe properly in TestImportMain

More generally I'm concerned about these tests using
$GOROOT/src/cmd/go as scratch space, especially
combined wtih tg.parallel() - it's easy to believe some other
test might inadvertently also try to write x.exe about the
same time. This CL only solves the "didn't clean up x.exe"
problem and leaves for another day the "probably shouldn't
write to cmd/go at all" problem.

Fixes #22266.

Change-Id: I651534d70e2d360138e0373fb4a316081872550b
Reviewed-on: https://go-review.googlesource.com/71410
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/71490
src/cmd/go/go_test.go