]> Cypherpunks repositories - gostls13.git/commit
database/sql: fix regression from earlier RawBytes fix
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 25 May 2023 21:52:01 +0000 (14:52 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 26 May 2023 03:06:19 +0000 (03:06 +0000)
commit145eec87683b4f09491bd4c6fc6448b920f4f4f3
treed3370ac8aa93bb9cb0b43f6c9a3a3a61d772ac88
parentf0e356a07d321ef674fcda71cd8014f055c10b07
database/sql: fix regression from earlier RawBytes fix

The earlier CL 497675 for #60304 introduced a behavior change
that, while not strictly a bug, caused a bunch of test failures
in a large codebase. Rather than add behavior changes in a 10 year
old package, revert to the old behavior: a context cancelation
between Rows.Next reporting false and a call to Rows.Err should
not result in Rows.Err returning the context error.

That behavior was accidentally added in CL 497675 as part of changing
how contexts and Rows iteration worked.

Updates #60304
Updates #53970

Change-Id: I22f8a6a6b0b5a94b430576cf50e015efd01ec652
Reviewed-on: https://go-review.googlesource.com/c/go/+/498398
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/database/sql/sql.go
src/database/sql/sql_test.go