]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.14] go/doc: fix detection of whole file examples
authorGregory Petrosyan <gregory.petrosyan@gmail.com>
Sat, 4 Apr 2020 15:27:23 +0000 (15:27 +0000)
committerDmitri Shuralyov <dmitshur@golang.org>
Mon, 11 May 2020 14:04:58 +0000 (14:04 +0000)
commit14c92c5f8032bcc45761e6f1759fa140dc131f76
tree9cdc9a0f492ea87244c14bb2ffc226ad91437b1e
parentf4274e64aac99aaa9af05988f2f8c36c47554889
[release-branch.go1.14] go/doc: fix detection of whole file examples

After CL 211357 (commit 499dc1c),
hasTests and numDecl were not updated properly for function
declarations with parameters, which affected the whole file
example detection logic. This caused examples like

package foo_test

func Foo(x int) {
}

func Example() {
fmt.Println("Hello, world!")
// Output: Hello, world!
}

to not be detected as whole file ones.

Fixes #38418.
For #38409.

Change-Id: I9ebd47e52d7ee9d91eb6f8e0257511de69b2a402
GitHub-Last-Rev: cc71c31124f6e3514f4e33ac7b169eca74c8bcb7
GitHub-Pull-Request: golang/go#37730
Reviewed-on: https://go-review.googlesource.com/c/go/+/222477
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit c4961dc247ca39c251a5a3c80ebfe59609b4e669)
Reviewed-on: https://go-review.googlesource.com/c/go/+/232868
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
src/go/doc/example.go
src/go/doc/example_test.go