]> Cypherpunks repositories - gostls13.git/commit
net/http: clarify that AddCookie only sanitizes the Cookie being added
authorVolker Dobler <dr.volker.dobler@gmail.com>
Tue, 26 May 2020 14:55:28 +0000 (16:55 +0200)
committerEmmanuel Odeke <emm.odeke@gmail.com>
Fri, 29 May 2020 09:21:54 +0000 (09:21 +0000)
commit1519bc4457af7179557a4f04bb35a4e07bedd118
treee8d9aa3d63547ec795fcdf725ee7b3afce3df81e
parent8f4151ea67e1d498e0880f28d3fd803dc2c5448f
net/http: clarify that AddCookie only sanitizes the Cookie being added

AddCookie properly encodes a cookie and appends it to the Cookie header
field but does not modify or sanitize what the Cookie header field
contains already. If a user manualy sets the Cookie header field to
something not conforming to RFC 6265 then a cookie added via AddCookie
might not be retrievable.

Fixes #38437

Change-Id: I232b64ac489b39bb962fe4f7dbdc2ae44fcc0514
Reviewed-on: https://go-review.googlesource.com/c/go/+/235141
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/http/request.go