]> Cypherpunks repositories - gostls13.git/commit
runtime: remove VDSO fallback test and benchmarks
authorIan Lance Taylor <iant@golang.org>
Wed, 1 May 2019 04:06:01 +0000 (21:06 -0700)
committerIan Lance Taylor <iant@golang.org>
Mon, 27 May 2019 17:58:39 +0000 (17:58 +0000)
commit1531192272dfdebc61050a8dafa626ff4b36b3a4
tree0aa06e1e8bb19d77f20e8580c3d7479fd82c6f00
parentd97bd5d07ac4e7b342053b335428ff9c97212f9f
runtime: remove VDSO fallback test and benchmarks

These tests assume that it is OK to switch between time implementations,
but the clock_gettime call uses CLOCK_MONOTONIC and the fallback call,
gettimeofday, uses CLOCK_REALTIME. Disabling the clock_gettime call means
that calls to nanotime will start returning very different values.
This breaks the new timer code, which assumes that nanotime will return
a consistently increasing value.

This test is not very useful in any case as it doesn't check the results.

Removing this file also removes BenchmarkTimeNow, which is a duplicate
of BenchmarkNow in the time package.

Updates #27707
Fixes #32109

Change-Id: I6a884af07f75822d724193c5eed94742f524f07d
Reviewed-on: https://go-review.googlesource.com/c/go/+/174679
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/vdso_linux_test.go [deleted file]