]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: disable rewrite loop detector for deadcode-only changes
authorKeith Randall <khr@golang.org>
Mon, 14 Mar 2022 22:17:43 +0000 (15:17 -0700)
committerKeith Randall <khr@golang.org>
Tue, 15 Mar 2022 00:05:18 +0000 (00:05 +0000)
commit15728ce950eea43d6f1b9fb29819d006071e843a
tree183e3d05e3e913a91f6fb8316e6a156d60208e76
parentb7041c7ad1c9d42078cfc376320e5b307e617a80
cmd/compile: disable rewrite loop detector for deadcode-only changes

We're guaranteed we won't infinite loop on deadcode-only changes,
because each change converts valid -> invalid, and there are only a
finite number of valid values.

The loops this test is looking for are those generated by rule
applications, so it isn't useful to check for loops when rules aren't
involved.

Fixes #51639

Change-Id: Idf1abeab9d47baafddc3a1197d5064faaf07ef78
Reviewed-on: https://go-review.googlesource.com/c/go/+/392760
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/compile/internal/ssa/rewrite.go