]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: delay expansion of OpArg until expand_calls
authorDavid Chase <drchase@google.com>
Tue, 13 Oct 2020 23:24:04 +0000 (19:24 -0400)
committerDavid Chase <drchase@google.com>
Thu, 29 Oct 2020 03:23:51 +0000 (03:23 +0000)
commit15f01d6ae9853fd51ee8842d9af93d04ce25458c
tree4ae2905a9ba92825989421a3d7a9c128d771c7fa
parent7fe2a84834537b58578791dd041b7bb40572620a
cmd/compile: delay expansion of OpArg until expand_calls

As it says, delay expanpsion of OpArg to the expand_calls phase,
to enable (eventually) interprocedural SSA optimizations, and
(sooner) change to a register ABI.

Includes a round of cleanup to function names and comments,
largely to match the expanded scope of the functions.

This CL removes the per-function dependence on GOSSAHASH,
but the go116lateCallExpansion kill switch remains (and was
tested locally to ensure it worked).

Two functions in expand_calls.go that performed overlapping
things were combined into a single function that is called
twice.

Fixes #42236.
For #40724.

Change-Id: Icbb78947eaa39f17f2c1210d5c2caef20abd6571
Reviewed-on: https://go-review.googlesource.com/c/go/+/262117
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/fmtmap_test.go
src/cmd/compile/internal/gc/ssa.go
src/cmd/compile/internal/ssa/compile.go
src/cmd/compile/internal/ssa/config.go
src/cmd/compile/internal/ssa/expand_calls.go
src/cmd/compile/internal/ssa/gen/dec64.rules
src/cmd/compile/internal/ssa/rewritedec64.go
src/cmd/compile/internal/ssa/stackalloc.go