]> Cypherpunks repositories - gostls13.git/commit
net, net/http: don't trace UDP dials
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 12 May 2016 22:12:11 +0000 (22:12 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 13 May 2016 01:19:05 +0000 (01:19 +0000)
commit15f2d0e45227f68024f3415d9466055877b70426
tree90c0192186ed90eddc63c9569bb04dea07f92164
parent4cffe44e361deb39e3274774a7984ab78a5b3931
net, net/http: don't trace UDP dials

The httptrace.ConnectStart and ConnectDone hooks are just about the
post-DNS connection to the host. We were accidentally also firing on
the UDP dials to DNS. Exclude those for now. We can add them back
later as separate hooks if desired. (but they'd only work for pure Go
DNS)

This wasn't noticed earlier because I was developing on a Mac at the
time, which always uses cgo for DNS. When running other tests on
Linux, I started seeing UDP dials.

Updates #12580

Change-Id: I2b2403f2483e227308fe008019f1100f6300250b
Reviewed-on: https://go-review.googlesource.com/23069
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/internal/nettrace/nettrace.go
src/net/dial.go
src/net/http/transport_test.go