]> Cypherpunks repositories - gostls13.git/commit
internal/sync: warn about incorrect unsafe usage in HashTrieMap
authorthepudds <thepudds1460@gmail.com>
Sat, 9 Aug 2025 21:25:14 +0000 (17:25 -0400)
committert hepudds <thepudds1460@gmail.com>
Mon, 11 Aug 2025 13:46:40 +0000 (06:46 -0700)
commit1718828c81f2bad44b51b13fb4b34540a9c2c096
tree98b5495cb3588b900b4af6db589559c71252bc0f
parent084c0f849467d5e45b7242cda3dd957352e86b8f
internal/sync: warn about incorrect unsafe usage in HashTrieMap

When the HashTrieMap expand method runs out of bits, it can be because
the user mutated a key after insertion using unsafe or similar
in violation of the HashTrieMap invariants.

Adjust the panic message to help triage and debugging by
more directly suggesting unsafe code might be at fault.

CL 694635 is a follow-up change that attempts to detect and
report illegally mutated keys sooner and more precisely.

Updates #74948
Updates #73427

Change-Id: Ib2bca067f0e212b8765c61183f59ac229513a823
Reviewed-on: https://go-review.googlesource.com/c/go/+/694376
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/internal/sync/hashtriemap.go