]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: update the incorrect assignment of call site offset.
authorJin Lin <jinl@uber.com>
Thu, 8 Feb 2024 20:52:07 +0000 (12:52 -0800)
committerCherry Mui <cherryyz@google.com>
Thu, 15 Feb 2024 21:30:35 +0000 (21:30 +0000)
commit185f31bf303b265b3a7b573a5fca613ca40bf503
tree6298262e03b241d614cbbe46f237ab9f3cc14720
parentb6ca586181f3f1531c01d51d632b50b2c7c784ba
cmd/compile: update the incorrect assignment of call site offset.

The call site calculation in the previous version is incorrect. For
the PGO preprocess file, the compiler should directly use the call
site offset value. Additionly, this change refactors the preprocess
tool to clean up unused fields including startline, the flat and the
cum.

Change-Id: I7bffed3215d4c016d9a9e4034bfd373bf50ab43f
Reviewed-on: https://go-review.googlesource.com/c/go/+/562795
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/cmd/compile/internal/pgo/irgraph.go
src/cmd/compile/internal/test/pgo_devirtualize_test.go
src/cmd/compile/internal/test/pgo_inl_test.go
src/cmd/compile/internal/test/testdata/pgo/devirtualize/devirt.pprof.node_map [new file with mode: 0644]
src/cmd/compile/internal/test/testdata/pgo/inline/inline_hot.pprof.node_map
src/cmd/preprofile/main.go