]> Cypherpunks repositories - gostls13.git/commit
net/http: eliminate arbitrary timeout in TestClientWriteShutdown
authorBryan C. Mills <bcmills@google.com>
Mon, 29 Nov 2021 20:17:36 +0000 (15:17 -0500)
committerBryan C. Mills <bcmills@google.com>
Tue, 30 Nov 2021 03:39:57 +0000 (03:39 +0000)
commit18934e11ba6ef2b2f21f091ddf4ab6814dcf1959
tree859ce0ed7e9d84a35ef315f445c4a9f1857b9671
parentf463b20789c89f0d22e56663a34e57a942f945cf
net/http: eliminate arbitrary timeout in TestClientWriteShutdown

This test occasionally hangs on the darwin-arm64-11_0-toothrot
builder. When it does, it fails with the unhelpful error message
"timeout" instead of a useful goroutine dump.

This change eliminates the use of an arbitrary timeout channel, so
that if (and probably when) the test hangs again we will get more
useful logs to diagnose the root cause.

For #49860

Change-Id: I23f6f1c81209f0b2dbe565e1dfb26b1b2eff0187
Reviewed-on: https://go-review.googlesource.com/c/go/+/367615
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/http/serve_test.go