]> Cypherpunks repositories - gostls13.git/commit
net: unskip and attempt to deflake TestAcceptTimeout
authorBryan C. Mills <bcmills@google.com>
Mon, 11 Dec 2023 21:45:04 +0000 (16:45 -0500)
committerGopher Robot <gobot@golang.org>
Tue, 23 Jan 2024 17:46:06 +0000 (17:46 +0000)
commit1a07550962a9f0123284a0efbe11c486fb1a452e
tree66d3384fad7be3cac31f07ec17eb5547831cb674
parented18d85ad798441e13d3b428678defb5bb0fb176
net: unskip and attempt to deflake TestAcceptTimeout

This test has been unconditionally skipped for over five years.
It may be that whatever was causing it to flake has been fixed.
And if it hasn't been fixed, it isn't providing any value.
Let's unskip it for the Go 1.23 development cycle and see what happens.

Let's also use a separate listener for each test case, so that a
leaked Dial goroutine from one case won't interfere with the other.

Fixes #17948 (maybe).

Change-Id: I239f22ca5d5a44388b9aa0ed4d81e451c6342617
Reviewed-on: https://go-review.googlesource.com/c/go/+/548940
Commit-Queue: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/net/timeout_test.go