]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.13] internal/syscall/windows/registry: remove TestWalkFullRegistr...
authorJason A. Donenfeld <Jason@zx2c4.com>
Sat, 26 Oct 2019 21:05:22 +0000 (23:05 +0200)
committerDmitri Shuralyov <dmitshur@golang.org>
Thu, 12 Mar 2020 21:49:10 +0000 (21:49 +0000)
commit1a1b02aca1acc4e315779eb7d0a242094abecc92
tree043788899a2cf1b0dfc76627ca2d840b97237b46
parente0f244d532a8b70a344c2e94abb852977e3fc9ea
[release-branch.go1.13] internal/syscall/windows/registry: remove TestWalkFullRegistry due to false assumptions

This test's existence was predicated upon assumptions about the full
range of known data types and known data into those types. However,
we've learned from Microsoft that there are several undocumented secret
registry types that are in use by various parts of Windows, and we've
learned from inspection that many Microsoft uses of registry types don't
strictly adhere to the recommended value size. It's therefore foolhardy
to make any assumptions about what goes in and out of the registry, and
so this test, as well as its "blacklist", are meaningless.

For #35084.
Fixes #37826.

Change-Id: I6c3fe5fb0e740e88858321b3b042c0ff1a23284e
Reviewed-on: https://go-review.googlesource.com/c/go/+/203604
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
(cherry picked from commit 0d3092ffa7e7f613429ddcfd596d26ccbc84766f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223237
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
src/internal/syscall/windows/registry/registry_test.go