]> Cypherpunks repositories - gostls13.git/commit
cmd/internal/obj: sort relocations
authorCherry Mui <cherryyz@google.com>
Mon, 28 Mar 2022 16:46:46 +0000 (12:46 -0400)
committerCherry Mui <cherryyz@google.com>
Mon, 28 Mar 2022 19:46:07 +0000 (19:46 +0000)
commit1a9972ec87de1eba7f9f71c8ed4afa88b0c122d4
treed49bbbbc49dd605561fd9fa8a32f8e3b9718ff26
parent33987b408c391433ad8214a56677e9af6463fd10
cmd/internal/obj: sort relocations

At least on some platforms (e.g. PE dynamic loader) relocations
need to be sorted in address order. Currently we don't always emit
relocations in address order: e.g. for array literal with out-of-
order element initializers, or out-of-order DATA instructions in
assembly code. Sort them.

No test for now as I can't reproduce the failure for #51923.

Fixes #51923.

Change-Id: Ifec5d3476e027bb927bcefd6e45c40ebeccee4ba
Reviewed-on: https://go-review.googlesource.com/c/go/+/396195
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/internal/obj/objfile.go