]> Cypherpunks repositories - gostls13.git/commit
misc/android: serialize adb commands on android emulators
authorElias Naur <mail@eliasnaur.com>
Mon, 25 Feb 2019 09:52:42 +0000 (10:52 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 26 Feb 2019 18:01:06 +0000 (18:01 +0000)
commit1aa0fcff465a7eb92836bdf343222cb34e9c6d33
tree074e484320054cb1c17d0de88935a3c5543e4f94
parente3d99a3f8608e308eedc201b83eeb2f0e0d9dc81
misc/android: serialize adb commands on android emulators

Android emulator builders are soon to join the trybot set. To avoid
flaky runs, work around a longstanding adb bug where concurrent adb
commands sometimes fail.

I haven't seen the problem on actual devices until recently. It seems
that the recently added "adb wait-for-device" can introduce flakyness
with errors such as:

adb: error: failed to get feature set: protocol fault (couldn't read status): Connection reset by peer

Instead of working around that, give up and serialize use of adb
everywhere.

Fixes #23795
Updates #23824

Change-Id: If347c9981fa32ff8a1e14b7454f122ef682450a6
Reviewed-on: https://go-review.googlesource.com/c/163625
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
misc/android/go_android_exec.go