]> Cypherpunks repositories - gostls13.git/commit
testing: callerName only needs one PC in the traceback
authorKeith Randall <keithr@alum.mit.edu>
Fri, 17 May 2019 20:31:12 +0000 (13:31 -0700)
committerKeith Randall <khr@golang.org>
Fri, 17 May 2019 22:32:30 +0000 (22:32 +0000)
commit1ab063ce532f72851cef735238ba656cc7680b66
tree202ab4622f3e28d1043fad727444aebea765ac33
parent5c3f3fbd0f91cf642e2d5c9109a2b3a9c65fe14b
testing: callerName only needs one PC in the traceback

callerName requested 2 PCs from Callers, and that causes
both to be looked up in the file/line mapping.
We really only need to do the work for one PC.
(And in fact the caller doesn't need file/line at all, but
the Callers API can't express that.)

We used to request 2 PCs because in 1.11 and earlier we
stored an inline skip count in the second entry.
That's not necessary any more (as of 1.12).

Fixes #32093

Change-Id: I7b272626ef6496e848ee8af388cdaafd2556857b
Reviewed-on: https://go-review.googlesource.com/c/go/+/177858
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Caleb Spare <cespare@gmail.com>
src/testing/testing.go