]> Cypherpunks repositories - gostls13.git/commit
net: remove arbitrary deadlines in PacketConn tests
authorBryan C. Mills <bcmills@google.com>
Wed, 1 Dec 2021 16:04:39 +0000 (11:04 -0500)
committerBryan C. Mills <bcmills@google.com>
Thu, 2 Dec 2021 05:26:57 +0000 (05:26 +0000)
commit1b2930d70c8bad5ecae08275e56e228e0f424b02
tree99d9aafb6ce5c93caacd5a1bcbb7825f96f2d07d
parent00dbcb33f8c20ce51de558cbc9de811b1ba0f70c
net: remove arbitrary deadlines in PacketConn tests

When TestPacketConn was added (in CL 6501057) it included arbitrary
100ms deadlines. Those deadlines were arbitrarily increased to 500ms
in CL 4922.

If the test is actually provoking a deadlock, allowing it to deadlock
will give us a more useful goroutine dump. Otherwise, the deadlines
don't seem all that useful — they appear to increase code coverage,
but have no effect on the test in the typical case, and can only
cause flakes on particularly-slow machines.

For #43627

Change-Id: I83de5217c54c743b83adddf51d4f6f2bd5b91732
Reviewed-on: https://go-review.googlesource.com/c/go/+/368215
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/net/packetconn_test.go