]> Cypherpunks repositories - gostls13.git/commit
internal/trace: make Reader output deterministic
authorRhys Hiltner <rhys.hiltner@gmail.com>
Tue, 2 Jul 2024 22:26:32 +0000 (15:26 -0700)
committerGopher Robot <gobot@golang.org>
Mon, 22 Jul 2024 21:23:42 +0000 (21:23 +0000)
commit1c4acea03d0e5d6bd1d6be74c816313f8ab109c3
treece155564a26fdc4cfd05dd5fbf6a3611b9d43107
parent601ea46a5308876e4460a1662718a9cd2c6ac2e3
internal/trace: make Reader output deterministic

Multiple Ms can offer Events with identical timestamps. The Reader
edits those so the timestamps are strictly increasing, but it needs a
way to break the tie. Use something deterministic (such as the order of
the batches), rather than map iteration order.

Updates #68277

Change-Id: I4a1f70c1669ce1c9b52d09e2bc99acbc831ef9a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/596355
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/internal/trace/generation.go
src/internal/trace/reader.go
src/internal/trace/trace_test.go