]> Cypherpunks repositories - gostls13.git/commit
os: further document limitations around naked file descriptors
authorVictor Michel <victor@optimyze.cloud>
Sun, 24 Jan 2021 05:53:36 +0000 (05:53 +0000)
committerIan Lance Taylor <iant@golang.org>
Tue, 26 Jan 2021 00:30:18 +0000 (00:30 +0000)
commit1d5e14632edc2ba76156c8a771a2a1a5c5387326
treecd1e7fa676577651a48e815f48e29379f694fc34
parentcf263e9f772eeeac21df6fe8f51a8c93e8ad5a27
os: further document limitations around naked file descriptors

NewFile requires the file descriptor to be either closed
through the returned File instance, or to stay valid at least
until the finalizer runs during garbage collection.

These requirements are easily violated when file descriptors
are closed via unix.Close, or when the *File returned by
NewFile is garbage collected while the underlying file descriptor is
still in use.

This commit adds further documentation for NewFile and Fd, making it
explicit that using naked file descriptors is subject to constraints
due to garbage collection of File objects.

Fixes #43863

Change-Id: I49ea1f0054eb2d2a72b616450c8e83476f4d07fb
GitHub-Last-Rev: 180d0130ae9009456914fb265b4bafa0e599de0e
GitHub-Pull-Request: golang/go#43867
Reviewed-on: https://go-review.googlesource.com/c/go/+/286032
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/os/file_unix.go