]> Cypherpunks repositories - gostls13.git/commit
[release-branch.go1.16] build: set GOPATH consistently in run.bash, run.bat, run.rc
authorRuss Cox <rsc@golang.org>
Wed, 27 Jan 2021 02:14:43 +0000 (21:14 -0500)
committerDmitri Shuralyov <dmitshur@golang.org>
Mon, 29 Mar 2021 19:16:21 +0000 (19:16 +0000)
commit1d967ab95c43b6b8810ca53d6a18aff85e59a3b6
tree435f5e6043fe616afc54db86a6e12cdc1c7962ca
parent9c7463ca903863a0c67b3f76454b37da0a400c13
[release-branch.go1.16] build: set GOPATH consistently in run.bash, run.bat, run.rc

We used to clear GOPATH in all the build scripts.
Clearing GOPATH is misleading at best, since you just end up
with the default GOPATH (%USERPROFILE%\go on Windows).
Unless that's your GOROOT, in which case you end up with a
fatal error from the go command (#43938).

run.bash changed to setting GOPATH=/dev/null, which has no
clear analogue on Windows.

run.rc still clears GOPATH.

Change them all to set GOPATH to a non-existent directory
/nonexist-gopath or c:\nonexist-gopath.

For #45238.
Fixes #45240.

Change-Id: I51edd66d37ff6a891b0d0541d91ecba97fbbb03d
Reviewed-on: https://go-review.googlesource.com/c/go/+/288818
Trust: Russ Cox <rsc@golang.org>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
(cherry picked from commit bb6efb96092cc8ae398c29e3b052a0051c746f88)
Reviewed-on: https://go-review.googlesource.com/c/go/+/304772
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
src/run.bash
src/run.bat
src/run.rc