]> Cypherpunks repositories - gostls13.git/commit
runtime: increase timeout in TestSpuriousWakeupsNeverHangSemasleep
authorMichael Anthony Knyszek <mknyszek@google.com>
Wed, 26 Feb 2025 23:11:29 +0000 (23:11 +0000)
committerGopher Robot <gobot@golang.org>
Fri, 28 Feb 2025 18:17:23 +0000 (10:17 -0800)
commit1dafccaaf324547c92fbba40e343d9a142f106b4
tree27548fd8f2345ac6bba3793a1289efc17d37a34a
parent6e8d7a113cc0f2cf59e0f67f86476cb003881a68
runtime: increase timeout in TestSpuriousWakeupsNeverHangSemasleep

This change tries increasing the timeout in
TestSpuriousWakeupsNeverHangSemasleep. I'm not entirely sure of the
mechanism, but GODEBUG=gcstoptheworld=2 and GODEBUG=gccheckmark=1 can
cause this test to fail at it's regular timeout. It does not seem to
indicate a deadlock, because bumping the timeout 10x make the problem
go away. I suspect the problem is due to the long STW times these two
modes can induce, plus the fact this test runs in parallel with others.

Let's just bump the timeout. The test is fundamentally sound, and it's
unclear to me how else to test for a deadlock here.

Fixes #71691.
Fixes #71548.

Change-Id: I649531eeec8a8408ba90823ce5223f3a17863124
Reviewed-on: https://go-review.googlesource.com/c/go/+/652756
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/semasleep_test.go