]> Cypherpunks repositories - gostls13.git/commit
cmd/asm: align an instruction or a function's address
authorfanzha02 <fannie.zhang@arm.com>
Thu, 19 Dec 2019 08:15:06 +0000 (08:15 +0000)
committerCherry Zhang <cherryyz@google.com>
Thu, 2 Apr 2020 15:05:15 +0000 (15:05 +0000)
commit1dbcbcfca4692f67db7de2c1ff6a5ee59511cfa4
tree3a2b59309bbecfc6af7653bb29c563db2e254378
parenta7a0f0305035948f4c86e08e6e64409ab11a6f67
cmd/asm: align an instruction or a function's address

Recently, the gVisor project needs an instruction's address
with 128 bytes alignment to fit the architecture requirement
for interrupt table.

This patch allows aligning an instruction's address to be
aligned to a specific value (2^n and in the range [8, 2048])

The main changes include:

1. Adds a new element in the FuncInfo structure defined in
cmd/internal/obj/link.go file to record the alignment
information.

2. Adds a new element in the Func structure defined in
cmd/internal/goobj/read.go file to read the alignment
information.

3. Adds the assembler support to align an intruction's offset
with a specific value (2^n and in the range [8, 2048]).
e.g. "PCALIGN $256" indicates that the next instruction should
be aligned to 256 bytes.

4. An instruction's alignment is relative to the start of the
function where this instruction is located, so the function's
address must be aligned to the same or coarser boundary.

This CL also adds a test.

Change-Id: I9b365c111b3a12f767728f1b45aa0c00f073c37d
Reviewed-on: https://go-review.googlesource.com/c/go/+/226997
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/cmd/internal/goobj/read.go
src/cmd/internal/obj/arm64/asm7.go
src/cmd/internal/obj/arm64/asm_test.go
src/cmd/internal/obj/link.go
src/cmd/internal/obj/objfile.go
src/cmd/link/internal/ld/data.go
src/cmd/link/internal/objfile/objfile.go
src/cmd/link/link_test.go