]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: use shorter version of movzx for LoweredHASCPUFeature
authorJakub Ciolek <jakub@ciolek.dev>
Sun, 11 Sep 2022 12:47:36 +0000 (14:47 +0200)
committerGopher Robot <gobot@golang.org>
Wed, 24 May 2023 22:27:06 +0000 (22:27 +0000)
commit1ddab592291584b2bd5b44b547618046d95c6abd
tree549be7063b98b25e480fd78de46312314d8625ab
parent15a4e0d9703033e0b2be4dc6830f03570df7943e
cmd/compile: use shorter version of movzx for LoweredHASCPUFeature

The values loaded from memory are booleans. Upper 32 bits are not needed.
Use the 32-bit version of movzx.

compilecmp linux/amd64:

math/bits
math/bits.OnesCount 83 -> 78  (-6.02%)

math
math.ceil 109 -> 103  (-5.50%)
math.Gamma changed
math.sinPi changed

runtime
runtime.(*sweepLocked).sweep changed
runtime.(*mspan).countAlloc 182 -> 178  (-2.20%)
runtime.(*pageBits).popcntRange 552 -> 542  (-1.81%)
go:(**mspan).runtime.countAlloc 243 -> 232  (-4.53%)
runtime.sweepLocked.countAlloc 221 -> 215  (-2.71%)
runtime.(*pageCache).allocN changed

math/rand
math/rand.(*Zipf).Uint64 506 -> 499  (-1.38%)

cmd/vendor/golang.org/x/sys/unix
cmd/vendor/golang.org/x/sys/unix.(*CPUSet).Count 147 -> 145  (-1.36%)

cmd/internal/obj/ppc64
cmd/internal/obj/ppc64.(*ctxt9).asmout changed

cmd/cover
main.htmlGen 1170 -> 1164  (-0.51%)

cmd/compile/internal/bitvec
cmd/compile/internal/bitvec.(*BitVec).Count 221 -> 213  (-3.62%)
cmd/compile/internal/bitvec.BitVec.Count changed

cmd/link/internal/loader
cmd/link/internal/loader.(*Bitmap).Count 214 -> 212  (-0.93%)
cmd/link/internal/loader.Bitmap.Count 171 -> 169  (-1.17%)
cmd/link/internal/loader.(*Loader).NReachableSym changed
cmd/link/internal/loader.(*Loader).Stat changed

cmd/vendor/github.com/ianlancetaylor/demangle
cmd/vendor/github.com/ianlancetaylor/demangle.oldRustToString changed

cmd/vendor/github.com/google/pprof/internal/graph
cmd/vendor/github.com/google/pprof/internal/graph.(*builder).addNode changed

cmd/compile/internal/ssa
cmd/compile/internal/ssa.rewriteValuePPC64_OpPPC64FTRUNC changed
cmd/compile/internal/ssa.(*regAllocState).computeLive 10441 -> 10409  (-0.31%)
cmd/compile/internal/ssa.(*regAllocState).regalloc changed
cmd/compile/internal/ssa.rewriteValuePPC64_OpPPC64FCEIL changed
cmd/compile/internal/ssa.(*regAllocState).allocReg changed
cmd/compile/internal/ssa.rewriteValuePPC64_OpPPC64FFLOOR changed
cmd/compile/internal/ssa.countRegs 83 -> 78  (-6.02%)

cmd/compile/internal/liveness
cmd/compile/internal/liveness.ArgLiveness.func2 changed

cmd/compile/internal/amd64
cmd/compile/internal/amd64.ssaGenValue changed

file                               before   after    Δ       %
math/bits.s                        2618     2613     -5      -0.191%
math.s                             37246    37240    -6      -0.016%
runtime.s                          486910   486879   -31     -0.006%
math/rand.s                        9980     9973     -7      -0.070%
cmd/vendor/golang.org/x/sys/unix.s 119232   119230   -2      -0.002%
cmd/cover.s                        31341    31335    -6      -0.019%
cmd/compile/internal/bitvec.s      5542     5534     -8      -0.144%
cmd/link/internal/loader.s         75315    75311    -4      -0.005%
cmd/compile/internal/ssa.s         3570581  3570544  -37     -0.001%
total                              20041552 20041446 -106    -0.001%

Change-Id: I29845744c512a1f833cb1fa3bb43b6b0e0eaac68
Reviewed-on: https://go-review.googlesource.com/c/go/+/430175
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/compile/internal/amd64/ssa.go